Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service question generator #52

Merged
merged 11 commits into from
Mar 13, 2024
Merged

Service question generator #52

merged 11 commits into from
Mar 13, 2024

Conversation

AbelMH1
Copy link

@AbelMH1 AbelMH1 commented Mar 13, 2024

Added a first version of the question generator service. The api succesfully answers incoming requests but the questions returned are directly generated from a simple wikidata query. Pending to test if it succesfully conects and posts the generated questions to the Question Storing Service. It is required to complete first the pull requests of that service (#50 )

@AbelMH1 AbelMH1 marked this pull request as ready for review March 13, 2024 20:16
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Author

@AbelMH1 AbelMH1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El código está bastante sucio debido a la implementación a última hora (por el abandono de un miembro del equipo) de la consulta a Wikidata, sin embargo, parece funcionar todo correctamente. Se refactorizará y limpiará el código para la próxima entrega.

@marco-qg marco-qg merged commit 6f7a9f8 into develop Mar 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants