Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friends locations proper rendering #71

Merged
merged 9 commits into from
Apr 23, 2023
Merged

Conversation

Manuhcuartas
Copy link
Contributor

I finally managed to make it work, the way it is done is the following:

  1. Everytime a new user enters the application and the LoMap folder is created (The one we use in order to manage all the data related with the application). It creates an empty locations.ttl file where all the locations should be stored.
  2. Once the folder and the file are both created it sets the permissions to append and read to all the friends in the SOLID friends list of the user.
  3. Once all the before commented is set up, everytime the friends of such user login in the application they should be able to see their friends added locations without a problem.

@Manuhcuartas Manuhcuartas self-assigned this Apr 19, 2023
@Manuhcuartas Manuhcuartas added the enhancement New feature or request label Apr 19, 2023
@Manuhcuartas Manuhcuartas linked an issue Apr 19, 2023 that may be closed by this pull request
RaduSeba
RaduSeba previously approved these changes Apr 19, 2023
Copy link
Contributor

@RaduSeba RaduSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be fully working.

@RaduSeba RaduSeba dismissed their stale review April 19, 2023 12:06

I tryed to run the code and the app crashed and now I can t login again.

@RaduSeba RaduSeba self-requested a review April 19, 2023 12:06
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getThing() method should be removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When i run the app i got this:
image

I merged it with master to check if it was up to date and it was
@juanmglzs do you get that too?

@FdezAriasSara
Copy link
Contributor

FdezAriasSara commented Apr 23, 2023

I deleted the duplicate of writeLocations method in my local copy and it did run

the thing is, my locations are not loading( nor are manus, which is my pod friend)

im assuming this is because the new folder structure?? @Manuhcuartas
Everything else seems to be working..

2023-04-23.20-52-06.mp4

EDIT: Is totally because of that, sorry
image

I Will rearrange my locations to the new folder and check that we are friends ,and i'll try again

Copy link
Contributor

@FdezAriasSara FdezAriasSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works after deleting the repeated writeLocations method!

proof

2023-04-23.21-10-21.mp4

@Manuhcuartas Manuhcuartas merged commit 815e2b6 into master Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants