feat: add OITracer to autoinstrumentations providing support for attribute masking and context attribute inheritance #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibute masking and context attribute inheritance
dosubot
bot
added
the
size:L
cephalization
approved these changes
Oct 23, 2024
dosubot
bot
added
size:XL
Parker-Stafford
commented
Oct 23, 2024
| private oiTracer: OITracer; | ||
|
|
||
| constructor( | ||
| config?: InstrumentationConfig & { traceConfig?: TraceConfigOptions }, |
There was a problem hiding this comment.
this is probably fine, for openai iu put them under two different keys to be less confusing, maybe it's more though? Also i added doc comment to try and help
Co-authored-by: Anthony Powell <[email protected]>
Parker-Stafford
deleted the
parker/5084-use-oitracer-in-auto-instrumentors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves Arize-ai/phoenix#5084