Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(semcov): llm system and llm provicer conventions #1071

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Oct 18, 2024

Adds conventions for llm.system and llm.provider so that collectors and user can more easily distinguish different permutations of systems and providers (e.g. openai system on azure etc)

@mikeldking mikeldking requested review from a team as code owners October 18, 2024 17:39
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 18, 2024
@mikeldking mikeldking changed the title llm system conventions feat(semcov): llm system and llm provicer conventions Oct 18, 2024
cspell.json Show resolved Hide resolved
OPENAI = "openai"
ANTHROPIC = "anthropic"
COHERE = "cohere"
MISTRALAI = "mistralai"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing vertex here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 18, 2024
@mikeldking
Copy link
Contributor Author

@mikeldking mikeldking merged commit d200d85 into main Oct 18, 2024
4 checks passed
@mikeldking mikeldking deleted the llm-system-conventions branch October 18, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants