Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve the document diff function to prevent partial ordering issues #7217

Merged
merged 13 commits into from
Jan 16, 2025
Merged

fix: improve the document diff function to prevent partial ordering issues #7217

merged 13 commits into from
Jan 16, 2025

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Jan 15, 2025 •
edited
Loading

Feature Preview

  • combine the insert operations if their paths are continuous.
  • update the update operations if they are ordered to match the new index.
  • combine the delete operations if their paths are continuous.
  • tests

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@LucasXu0 LucasXu0 marked this pull request as draft January 15, 2025 07:41
@LucasXu0 LucasXu0 changed the title fix: improve the document diff function to prevent partial ordering i… fix: improve the document diff function to prevent partial ordering issues Jan 15, 2025
@LucasXu0 LucasXu0 marked this pull request as ready for review January 15, 2025 12:39
@LucasXu0 LucasXu0 merged commit f35dfaf into AppFlowy-IO:main Jan 16, 2025
18 checks passed
@rananisar348
Copy link

e4bdea3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v0.8.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucasXu0 @rananisar348