-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: timer field #5349
feat: timer field #5349
Conversation
* main: chore: update German translations with Fink 🐦 (AppFlowy-IO#5335) chore: bump version 0.5.8 (AppFlowy-IO#5341) fix: add space above logo (AppFlowy-IO#5334) feat: adjust font background color in dark mode (AppFlowy-IO#5333) feat: support enter to insert new line in callout (AppFlowy-IO#5331) chore: update translations with Fink 🐦 (AppFlowy-IO#5321) fix: font family warning (AppFlowy-IO#5329) fix: show windows title bar on sign in screen (AppFlowy-IO#5326) fix: view action not working (AppFlowy-IO#5325) fix: text update bug on number/url fields (AppFlowy-IO#5315) feat: settings manage data (AppFlowy-IO#5265) chore: improve floating mobile toolbar animation for iOS (AppFlowy-IO#5309) chore: udpated yrs to v0.18.8 (AppFlowy-IO#5316) fix: page style issues (AppFlowy-IO#5317) feat: custom windows title bar (AppFlowy-IO#5311)
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
lint rule | new reports | level | link |
---|---|---|---|
Missing translation | 26 | warning | contribute (via Fink 🐦) |
* main: fix: unable to remove the remote selection when the user close the page on mobile (AppFlowy-IO#5376) chore: add limitation when importing csv file (AppFlowy-IO#5381) fix: infinite loop when getting ancestor for orphan view (AppFlowy-IO#5375) fix: range error raise if heading level >= 6 (AppFlowy-IO#5373) fix: use full update states instead of patch update (AppFlowy-IO#5371) chore: update translations to consistently use appName instead of AppFlowy (AppFlowy-IO#5354) fix: changing field type from text to checkbox causes exception AppFlowy-IO#5360 (AppFlowy-IO#5366) fix: heading node validate failed (AppFlowy-IO#5370) chore: support Ukrainian language AppFlowy-IO#5350 (AppFlowy-IO#5369) chore: do not use the cell of given summary field (AppFlowy-IO#5362) chore: update translations with Fink 🐦 (AppFlowy-IO#5322) chore: update fr-FR.json (AppFlowy-IO#5356) fix: workspace icon displays incorrectly on Linux (AppFlowy-IO#5358) feat: support web grid preview (AppFlowy-IO#5353)
2024-05-21.13-03-00.mp4 |
frontend/rust-lib/flowy-database2/src/services/field/type_options/timer_type_option/timer.rs
Outdated
Show resolved
Hide resolved
Also something I was thinking about when I saw "Timer", is that I was expecting it to count down. Otherwise I guess calling it "Time" is more relevant. |
You are right about timer but I think maybe stopwatch is a better name. I also want to add time tracking feature to this later and it works like count up. |
Thinking about this, It can be a general field type (I'm not sure about the name) which the user can choose to be a timer (count down) or stopwatch (count up) in type options. What do you think @Xazin? |
Yeah that is a good idea. Kind of like selecting a number format. |
So I will change the field type name to Time and will add a stopwatch and timer option later in a separate PR. |
Sounds good, feel free to ping me when you have renamed the field, I tested and feature works as expected. 👍 I think the time type data can be in minutes, but for Stop timer or Count down timer, it should be a start timestamp. |
* main: (25 commits) fix: sidebar issues (AppFlowy-IO#5444) fix: notification test (AppFlowy-IO#5440) fix: some list icons don't align with the paragraph (AppFlowy-IO#5439) feat: integrate show notification button option (AppFlowy-IO#5302) feat: add border to selected unsplash image (AppFlowy-IO#5428) feat: sidebar UI Revamp on mobile (AppFlowy-IO#5418) chore: update German translations with Fink 🐦 (AppFlowy-IO#5421) chore: update Spanish translations (AppFlowy-IO#5205) feat: video block support (AppFlowy-IO#5199) feat: add reset app scale hotkey (AppFlowy-IO#5386) fix: sidebar issues on Windows and Linux (AppFlowy-IO#5431) feat: support web layout setting and breadcrumbs (AppFlowy-IO#5425) fix: dragging the Unsplash cover triggers an assertion error (AppFlowy-IO#5404) chore: improve hover and text colors in dark mode (AppFlowy-IO#5416) fix: accept multi-key combination for customizing shortcuts & removes duplicates (AppFlowy-IO#5414) feat: sidebar UI Revamp on Desktop (AppFlowy-IO#5343) fix: default text direction not synced (AppFlowy-IO#5405) chore: update German translations (AppFlowy-IO#5382) feat: support preview grid/board/calendar block on web (AppFlowy-IO#5401) feat: support open row page (AppFlowy-IO#5400) ...
@Xazin I renamed the field type to time and moved the formatting function to the flutter frontend.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5349 +/- ##
==========================================
+ Coverage 9.70% 86.74% +77.04%
==========================================
Files 685 217 -468
Lines 31812 5032 -26780
Branches 0 831 +831
==========================================
+ Hits 3086 4365 +1279
+ Misses 28726 561 -28165
- Partials 0 106 +106
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Timer field type which stores time in minutes. More details about this feature on the related issue #4083.
Resolves #4083.
Feature Preview
PR Checklist