Fix: Enable more text to be translated #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires these to be merged first: |
jpenna
force-pushed
the
4276-translations
branch
2 times, most recently
from
ffae604 to
65aeb0b
Compare
When customizing shortcuts, the key was used for the description of the shortcut. Since the key is hardcoded, is defined at compile time and shouldn't depend on locale, a new field `description` was added to the commands to provide the localized description.
The tool that requries this file (called "asdf") is suggested in the AppFlowy's documentation for installing Flutter and Dart, so it makes sense to have it ignored by default. Maybe it should be committed, so it whould be easier to keep all contributors with the same Flutter version.
jpenna
force-pushed
the
4276-translations
branch
from
65aeb0b to
c04158a
Compare
|
Hey @jpenna Seems some unit tests are failing, can you take a look? |
|
Yes, I'll take a look next week! |
LucasXu0
added
translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Preview
partially fixes #4276 by allowing for shortcuts to be translated.
PR Checklist