Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include default services into extras #1165

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

thuvh
Copy link
Contributor

@thuvh thuvh commented Jan 15, 2025

it easier to use docker-compose-extras

@khorshuheng khorshuheng self-requested a review January 15, 2025 04:03
@khorshuheng
Copy link
Collaborator

Thanks, could you update the commit message to follow the following format:
"chore: include default services into extras" ?

In addition, can you update this section (https://github.com/AppFlowy-IO/AppFlowy-Cloud/blob/main/doc/DEPLOYMENT.md#4-optional-services) , so that users will know that docker compose extra will also include docker compose?

@thuvh thuvh changed the title include default services into extras chore: include default services into extras Jan 15, 2025
@thuvh thuvh force-pushed the compose_include_defaults branch from 645a57c to 8ee8422 Compare January 15, 2025 06:19
@CLAassistant
Copy link

CLAassistant commented Jan 15, 2025

CLA assistant check
All committers have signed the CLA.

@khorshuheng khorshuheng merged commit d634df0 into AppFlowy-IO:main Jan 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants