-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 collab cache #1028
Merged
Merged
S3 collab cache #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Horusiath
force-pushed
the
a3-collab-cache
branch
from
November 28, 2024 05:02
68d7a6d
to
1867d8f
Compare
Horusiath
force-pushed
the
a3-collab-cache
branch
from
December 2, 2024 12:16
802aed7
to
a216a7e
Compare
appflowy
reviewed
Dec 3, 2024
appflowy
reviewed
Dec 3, 2024
appflowy
reviewed
Dec 3, 2024
appflowy
reviewed
Dec 3, 2024
Horusiath
force-pushed
the
a3-collab-cache
branch
from
December 3, 2024 03:52
473375e
to
e41ca8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements
DiskCache
to store encoded collabs in S3-compatible storage rather than in Postgres. Postgres is used only as a fallback for compatibility with an existing storage model.TODOs:
S3_COLLAB_THRESHOLD
, 2000 bytes), so that any collab data smaller than that threshold will still land in Postgres. PS: All new snapshots are always stored in S3 regardless of size.