Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jazzy harmonic devel #34

Open
wants to merge 10 commits into
base: humble_devel
Choose a base branch
from

Conversation

Kaiser1401
Copy link

Attempt to take humble devel and make it run on jazzy using gz-harmonic.

not everything as i like yet, but maybe worth a branch

@AndrejOrsula
Copy link
Owner

Hey @Kaiser1401,

Oh wow, I am impressed that someone actually attempted this. Thanks a lot for your effort and for making it public via this PR.

I have not used this repository for quite some time, and I am busy with other things, so I won't have time to try it anytime soon. But I can merge it into a new branch whenever you think it is ready-ish.

Also — by any chance, have you checked if there are any "official" alternatives available by now? This repository was quickly put together when I needed it several years ago, but I hope/thought there would be proper support by now.

Thanks again!

@Kaiser1401
Copy link
Author

Kaiser1401 commented Jun 6, 2024

I have mainly looked around for a working example combining GazeboSim, Ros2, MoveIt and a manipulator arm interacting with something and so far this seemed to be the best starting point :D

I have seen the comment that moveIt now has it's own python api but have not checked it yet.

I'm fairly new to ROS2, GZ and MoveIt (but have quite som experienc from ROS1) so this is a bit my starting point. While somehting running would have been ideal to use it, fixing things also seems to teach me quite a bit.

I'll probably have accompanying changes for the ign_moveit2__examples pkg. I'll let you know when I think it's runnable.

Also; for reference on changes to request_adapters etc in planning config: MoveIt Migration Notes

@Kaiser1401 Kaiser1401 marked this pull request as ready for review June 10, 2024 13:40
@Kaiser1401
Copy link
Author

This basically should work, not everything tidied up.

Copy link
Owner

@AndrejOrsula AndrejOrsula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the contribution @Kaiser1401! The changes look good to me, although I didn't check the updated parameters/adapters as I do not keep up to date with their changes.

@@ -9,7 +9,8 @@
controller_parameters
">
<gazebo>
<plugin filename="ign_ros2_control-system" name="ign_ros2_control::IgnitionROS2ControlPlugin">
<!-- <plugin filename="ign_ros2_control-system" name="ign_ros2_control::IgnitionROS2ControlPlugin"> -->
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to keep the old name

Suggested change
<!-- <plugin filename="ign_ros2_control-system" name="ign_ros2_control::IgnitionROS2ControlPlugin"> -->

@@ -0,0 +1,140 @@
#!/usr/bin/env -S ros2 launch
"""Example of planning with MoveIt2 and executing motions using fake ROS 2 controllers within RViz2"""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move this script under panda/launch (add launch to its cmake), and call it something like gz.launch.py (suggestion)? I think that will make it more clean and discoverable.

@@ -0,0 +1,140 @@
#!/usr/bin/env -S ros2 launch
"""Example of planning with MoveIt2 and executing motions using fake ROS 2 controllers within RViz2"""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Example of planning with MoveIt2 and executing motions using fake ROS 2 controllers within RViz2"""
"""Example of planning with MoveIt2 and executing motions using simulated Gazebo robot"""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants