fix: named response is only set, if all testResults are valid

CHANGELOG.md

@@ -1,10 +1,14 @@
+## [6.16.2] (2024-10-29)
+
+### Fix
+- named response is only set, if all testResults are valid
+
 ## [6.16.1] ( 2024-10-29)
 
 ### Fix
-- support `http_proxy` environment variable
+- support `https_proxy` environment variable
 - support html mimetype for dom parser and use only valid mimetype in parseFromString
 
-
 ## [6.16.0] ( 2024-10-28)
 ### Features
 - support client certificates on OAuth2 Requests (#802)

package.json

@@ -4,7 +4,7 @@
   "license": "MIT",
   "publisher": "AnWeber",
   "description": "HTTP/REST CLI Client for *.http files",
-  "version": "6.16.1",
+  "version": "6.16.2",
   "homepage": "https://github.com/AnWeber/httpyac",
   "repository": {
     "type": "git",

src/plugins/core/execute/index.ts

@@ -1,5 +1,6 @@
 export * from './createRequestInterceptor';
 export * from './lazyVariableInterceptor';
 export * from './logResponseInterceptor';
+export * from './metaDataNameInterceptor';
 export * from './processedHttpRegionInterceptor';
 export * from './regionScopedVariablesInterceptor';

src/plugins/core/execute/metaDataNameInterceptor.ts

@@ -0,0 +1,37 @@
+import * as models from '../../../models';
+import * as utils from '../../../utils';
+
+import { HookInterceptor, HookTriggerContext } from 'hookpoint';
+
+export class MetaDataNameInterceptor implements HookInterceptor<[models.ProcessorContext], boolean | void> {
+  id = 'metaDataName';
+  async afterLoop(
+    hookContext: HookTriggerContext<[models.ProcessorContext], boolean | undefined>
+  ): Promise<boolean | undefined> {
+    const context = hookContext.args[0];
+    if (!context.httpRegion.response || !utils.isString(context.httpRegion.metaData.name)) {
+      return true;
+    }
+
+    if (
+      context.httpRegion.testResults &&
+      context.httpRegion.testResults.some(t => t.status !== models.TestResultStatus.SUCCESS)
+    ) {
+      return true;
+    }
+
+    const name = context.httpRegion.metaData.name
+      .trim()
+      .replace(/\s/gu, '-')
+      .replace(/-./gu, value => value[1].toUpperCase());
+    utils.setVariableInContext(
+      {
+        [name]: context.httpRegion.response.parsedBody || context.httpRegion.response.body,
+        [`${name}Response`]: context.httpRegion.response,
+      },
+      context
+    );
+
+    return true;
+  }
+}

src/plugins/core/registerCorePlugin.ts

@@ -37,7 +37,6 @@ function initOnRequestHook(api: models.HttpyacHooksApi) {
 }
 
 function initOnResponseHook(api: models.HttpyacHooksApi) {
-  api.hooks.onResponse.addHook('handleMetaDataName', response.handleNameMetaData);
   api.hooks.onResponse.addHook('setLastResponseInVariables', response.setLastResponseInVariables);
   api.hooks.onResponse.addInterceptor(response.jsonResponseInterceptor);
 }
@@ -95,6 +94,7 @@ function initExecuteInterceptor(api: models.HttpyacHooksApi) {
   api.hooks.responseLogging.addInterceptor(processedHttpRegionInterceptor.getResponseLoggingInterceptor());
   api.hooks.execute.addInterceptor(new execute.CreateRequestInterceptor());
   api.hooks.execute.addInterceptor(new execute.LazyVariableInterceptor());
+  api.hooks.execute.addInterceptor(new execute.MetaDataNameInterceptor());
   api.hooks.execute.addInterceptor(new execute.LogResponseInterceptor());
 }
 function initProvideEnvironmentsHook(api: models.HttpyacHooksApi) {

src/plugins/core/response/index.ts

@@ -1,3 +1,2 @@
-export * from './handleNameMetaData';
 export * from './jsonResponseInterceptor';
 export * from './setLastResponseInVariables';