Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eval): reliability improvement for SWE-Bench eval_infer #6347

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

xingyaoww
Copy link
Collaborator

@xingyaoww xingyaoww commented Jan 18, 2025

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

We didn't handle the AgentRuntime exception directly been throw from inside the eval_infer process_instance function.

This causes some failed instance did not trigger "retry with larger instance", causing the evaluation to get stuck.


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:30df16b-nikolaik   --name openhands-app-30df16b   docker.all-hands.dev/all-hands-ai/openhands:30df16b

@xingyaoww xingyaoww requested a review from neubig January 18, 2025 17:34
@xingyaoww xingyaoww marked this pull request as ready for review January 18, 2025 17:36
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 - Will this lead to more graceful behavior when a runtime fails to start due to an unexpected error?

@neubig neubig merged commit 2b04ee2 into main Jan 18, 2025
15 checks passed
@neubig neubig deleted the xw/swebench-eval-fix branch January 18, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants