DRAFT: Keycloak initial changes #6244
Draft
+1,089
−494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
reviewed
Jan 15, 2025
| @@ -7,5 +7,6 @@ | |||
| export const generateGitHubAuthUrl = (clientId: string, requestUrl: URL) => { | |||
| const redirectUri = `${requestUrl.origin}/oauth/github/callback`; | |||
| const scope = "repo,user,workflow,offline_access"; | |||
| return `https://github.com/login/oauth/authorize?client_id=${clientId}&redirect_uri=${encodeURIComponent(redirectUri)}&scope=${encodeURIComponent(scope)}`; | |||
| // return `https://github.com/login/oauth/authorize?client_id=${clientId}&redirect_uri=${encodeURIComponent(redirectUri)}&scope=${encodeURIComponent(scope)}`; | |||
| return `http://localhost:8080/realms/allhandsgithub/protocol/openid-connect/auth?client_id=allhandsgithub&response_type=code&redirect_uri=${encodeURIComponent(redirectUri)}&scope=openid+email+profile&state=some-state-value&nonce=222`; | |||
There was a problem hiding this comment.
I think this is really the only thing we need to change here. We should probably have a getAuthURL on the config that returns this, which could be configured to different auth providers
The other stuff here can probably get removed (e.g. no need for the OSS to have a "keycloak token" input, and we can handle the refresh logic in the SaaS backend)
baxitfund
approved these changes
Jan 20, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for keycloak integration.