Use pkg-config to get dependencies #14
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| HOMEBREW_BIN="${HOMEBREW_ROOT:-/opt/homebrew}/bin" | ||
|
There was a problem hiding this comment. Does modern homebrew installation set this variable? Mine (a few years old) definitely didn't. Anyway why not use |
||
| if [ -d "$HOMEBREW_BIN" ] ; then | ||
| PATH="$HOMEBREW_BIN:$PATH" | ||
| export PATH | ||
| else | ||
| echo "warning: $HOMEBREW_BIN doesn't exist. This build will likely fail." | ||
| echo "warning: If homebrew is installed elsewhere, set the HOMEBREW_ROOT environment variable." | ||
| fi | ||
|
|
||
| PACKAGES="pidgin gtk-mac-integration-gtk2" | ||
| PIDGIN_PATH="$(pkg-config pidgin --variable=prefix)/bin/pidgin" | ||
| OTHER_CFLAGS="$(pkg-config $PACKAGES --cflags-only-other)" | ||
| OTHER_LDFLAGS="$(pkg-config $PACKAGES --libs-only-l) -bundle_loader ${PIDGIN_PATH}" | ||
| HEADER_SEARCH_PATHS="$(pkg-config $PACKAGES --cflags-only-I | sed 's/^-I//g;s/ -I/ /g')" | ||
| LIBRARY_SEARCH_PATHS="$(pkg-config $PACKAGES --libs-only-L | sed 's/^-L//g;s/ -L/ /g')" | ||
|
|
||
| cat <<EOF > "${PROJECT_DIR}/Dependencies.xcconfig" | ||
|
There was a problem hiding this comment. I don't think it should write to a file that is a part of the repository. That generated file should be in gitignore otherwise it makes fictional changes. |
||
| // With Homebrew path = ${HOMEBREW_BIN} | ||
| OTHER_CFLAGS = \$(inherited) ${OTHER_CFLAGS} | ||
| OTHER_LDFLAGS = \$(inherited) ${OTHER_LDFLAGS} | ||
| HEADER_SEARCH_PATHS = \$(inherited) ${HEADER_SEARCH_PATHS} | ||
| LIBRARY_SEARCH_PATHS = \$(inherited) ${LIBRARY_SEARCH_PATHS} | ||
| EOF | ||
|
|
||
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering that Apple has basically stopped supporting
bashon macOS either pureshor at leastzshwould be a better idea.