Orientation normalisation before cropping/merging #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I'm not sure whether this issue appeared only in recent versions of iOS, as I have not tested anything but 9.x. Yet now this method is not working correctly for rotated images - 'applyTintEffectWithColor:atFrame:'.
Frame is applied correctly, to a correct part to an image. But then it is stretched incorrectly and inserted into a wrong position. Please see screenshot for example:
http://take.ms/BPlY8
Left side is correct (fixed) highlight.
Right side takes an originally rotated image (captured by the camera 'on the side'), crops desired area, blurs it, but then stretches it incorrectly and inserts into wrong position.
I fixed this by 'normalising' image first - translating into OrientationUp, if it's not already.
Original code is doing this again implicitly later on, when two images are merged, thus forcing OrientationUp any way.
Does it make sense to merge this fix and release a Pod update?
Btw, thank you for the library :)