Major cleanup #15
Open
Major cleanup #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDK if this works becuase the tests run but never finish, debug output shows that the search runs but doesn't find a solution. The script managed to allocate as much as 6GBs of RAM without finding any solution, judging by the amount of (unjustified) use of
operator new, it wouldn't be a surprise if many leaks are hiding in the codebase.Major work is required to port C-with-classes semantics to proper C++11 to ensure that the code is safe, but this requires domain knowledge that I lack, so if you want you can pick up the work from here.