Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lauren pipes scrabble #46

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

lauren pipes scrabble #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
aa5c3b1
set up files
laurenelee Nov 14, 2017
7b56f8b
score method
laurenelee Nov 14, 2017
9e22660
writing score method
laurenelee Nov 14, 2017
5fc45b1
moving into highestScoreFrom method
laurenelee Nov 14, 2017
b4303b5
highestScoreFrom passes tests
laurenelee Nov 14, 2017
81b8349
working on methods for player
laurenelee Nov 14, 2017
77f6fe7
tests passing, cleaning up
laurenelee Nov 15, 2017
6f8a5c8
method names
laurenelee Nov 15, 2017
89bc2e3
moving checking validity outside of object
laurenelee Nov 15, 2017
ca9f267
refactoring checkvalidity
laurenelee Nov 15, 2017
57d7191
pull request questions
laurenelee Nov 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ Congratulations! You're submitting your assignment!
## Comprehension Questions
| Question | Answer |
| :------------- | :------------- |
| What patterns were you able to use from your Ruby knowledge to apply to JavaScript? | |
| What was a challenge you were able to overcome on this assignment? | |
| What is your favorite thing about learning a new programming language? | |
| What is your least favorite thing about learning a new programming language? | |
| Do you have any recommendations on how we could improve this project for the next cohort? | |
| What patterns were you able to use from your Ruby knowledge to apply to JavaScript? | I was able to use similar nested if-loops to check against the tie scenarios. Same logic applied to most everything in this problem, I just needed to switch syntax. It was the same pattern of checking the first word in the array against the next and evaluating it. |
| What was a challenge you were able to overcome on this assignment? | I struggled with understanding when to call 'this' and when to call the object 'Scrabble'. I also wanted to DRY up my checkValidity function that I call twice and I overcame that tricky spot but pulling out completely and making it more of a 'globally scoped' function. |
| What is your favorite thing about learning a new programming language? | I am loving that the translation portion of it and it has been fun to revel in the differences. It's neat that JS doesn't have the same functionality as ruby and now we are in the exploration phase of what those differences and similarities are. It's proving to be pretty fun and fascinating! |
| What is your least favorite thing about learning a new programming language? | Syntax confusion. Not quite knowing how to search for what I am needing on the internet. But I'm sure this is normal and is just my own growing-pains that will get better with time and effort. |
| Do you have any recommendations on how we could improve this project for the next cohort? | I wonder if we could have used two classes as opposed to an object and class within that object. Just because it was what we had been working on in class on Tuesday it would have been fun to apply that new knowledge! |
269 changes: 269 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
"dependencies": {
"eslint-plugin-jasmine": "^2.9.1",
"jasmine": "^2.8.0",
"jasmine-expect": "^3.8.1"
"jasmine-expect": "^3.8.1",
"prompt": "^1.0.0"
},
"scripts": {
"test": "jasmine"
Expand Down
Loading