Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIPES - Kimberley Zell - JS-Scrabble #28

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kimpossible1
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Making a class, if statements, split function, etc. The general logic is nearly the same, it's just a matter of syntax and working with/around quirks of javascript.
What was a challenge you were able to overcome on this assignment? I had some challenges with implementing the throws. They at first caused a lot of other tests that were previously passing to fail. I also found that javascript does not always behave as I would expect, for example I found that NaN does not equal NaN, and it seems like comparing arrays to see if they are does not always work. Basically, I could not take for granted that anything I did would 100% perform with the same behavior as I have learned to expect from Ruby, so I tested each thing I was doing to make sure what kind of result I would get.
What is your favorite thing about learning a new programming language? I am curious about what more the language can do, but so far I think it has been nice to see how a lot of the same principles can still apply between languages so it was basically re-solving a problem that I had already solved, now with slightly different rules of the language and different syntax. It was fun to solve the puzzles of the new language and work around/with the different behavior.
What is your least favorite thing about learning a new programming language? I don't care much for being presented with a lot of different ways to write the same or similar code when first learning something new. I prefer to stick with a consistent way of writing the code, and then learn other ways in the future and as necessary. For example, arrow methods and even the different ways of writing them -- I don't see a strong point in using all of that different syntax though I can appreciate knowing it exists. It seems like most programmers don't know it yet and it's not being used that much, so I think I'd rather stick with the more traditional syntax.
Do you have any recommendations on how we could improve this project for the next cohort? Overall I liked this assignment. I think it's the right level of difficulty for a first project in js, given js was not our first language. Since it was very similar to our previous scrabble project, I felt it was confidence building to be able to write it now in js. I would have struggled a lot more if the instructions had been less clear and/or the structure been less set up to get us started, so I appreciated the level of detail given. I did struggle with interpreting the wording on some of the instructions, but for the most part it went well.

@PilgrimMemoirs
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Well Done
Comprehension questions Well Done - thanks for the feedback
General
score calculates score, has appropriate params and return value Well Done
highestScoreFrom calculates highest scoring word, has appropriate params and return value Well Done
Player object
Has name and plays properties Well Done
Has play, totalScore, hasWon functions Well Done
Has highestScoringWord and highestWordScore functions Mostly Good - does highestScoringWord need an argument? You can call it without, and you're not using it within anyway.
Overall
Submission meets project expectations, nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants