Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaunna Wiens --carets #24

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Shaunna Wiens --carets #24

wants to merge 17 commits into from

Conversation

skwiens
Copy link

@skwiens skwiens commented Nov 17, 2017

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Knowledge of loops and classes
What was a challenge you were able to overcome on this assignment? Using arrow functions as well as using loops in general. While it is similar, the syntax is different. I also struggled with not having a way to iterate through an object (while I know that I can using a for...in loop, that isn't approved by the ruby style guide). Instead, I iterated through the keys of the object and called what I needed from the values that way.
What is your favorite thing about learning a new programming language? The learning curve... the more you know, the slower the learning curve is. Within a few days I can write some basic things in Javascript which took me such a long time to figure out in Ruby. It's also fun to look at what languages allow, don't allow, and how they express themselves and lend themselves to some things better than others. I feel like spoken languages can be the same way, so it's fun to see the different ways to use a new language and see how it is similar and different and how even the similarities come across differently.
What is your least favorite thing about learning a new programming language? Red dots.
Do you have any recommendations on how we could improve this project for the next cohort? If it would be possible without too much work on the part of the instructors, it would be fun to have a game similar to that which we designed in Ruby, but different. I heard one person suggest something like Yatzee. (This is fun too though!)

@CheezItMan
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Really nice granular commits with good commit messages!
Comprehension questions Check, we'll look at Yatzee. The linter does complain and it's not fun, but it will help your code.
General
score calculates score, has appropriate params and return value Check
highestScoreFrom calculates highest scoring word, has appropriate params and return value Check
Player object
Has name and plays properties Check
Has play, totalScore, hasWon functions Check
Has highestScoringWord and highestWordScore functions Check
Overall Really nice work adding your own tests with TileBag! I also like how you used regular expressions. Really excellent submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants