Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jessica Owens -- Carets #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Jessica Owens -- Carets #22

wants to merge 4 commits into from

Conversation

vertige
Copy link

@vertige vertige commented Nov 17, 2017

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Instance methods, loops and conditionals. I'd like to hear more about patterns and what that really means. We hear about them, but it'd be cool to get more examples/reference of what that means. Basically, most of the logic seems to apply. The construction and syntax is slightly different. The limits/nuances are different, but Ruby seemed pretty loose to me, and JavaScript seems even more varietal in syntax. We shall see!
What was a challenge you were able to overcome on this assignment? I'm not sure I overcame any... I still find the style guide/linter hard to work without extra spacing between lines, but it's teaching me some other things. I'm a little worried about learning some of the newer methods (arrow functions) and not being very familiar with older syntax. And I completely forgot to commit to the Git.
What is your favorite thing about learning a new programming language? Seeing how things do and don't translate. I always think about how little I knew about my native English until learning French and subsequent languages. It's really fun. Except maybe commas versus semi-colons...
What is your least favorite thing about learning a new programming language? Linters everywhere. It's really nice to get some insight into some of the finicky nuance of the differences between and within a language from another human. I think that's the benefit of learning about coding in a school environment for me. Not that Google isn't great, but it definitely seems to click faster when digging in and discussing. I can't (won't) go through every case/iteration/variety myself.
Do you have any recommendations on how we could improve this project for the next cohort? I liked the fact that this was like refactoring a project. I feel like most of these projects get left in the dust. It was a nice change.

@tildeee
Copy link

tildeee commented Nov 27, 2017

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yup you knew you forgot to git! :)
Comprehension questions x
General
score calculates score, has appropriate params and return value x
highestScoreFrom calculates highest scoring word, has appropriate params and return value x
Player object
Has name and plays properties x
Has play, totalScore, hasWon functions x
Has highestScoringWord and highestWordScore functions x
Overall

Very small note, but I love the line of code total += this.LetterValues[${word[i].toUpperCase()}]; . It just looks so nice :)

Overall great code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants