forked from AdaGold/ada-trader
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carets —Amy Lee #40
Open
ayjlee
wants to merge
21
commits into
Ada-C8:master
Choose a base branch
from
ayjlee:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Carets —Amy Lee #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uccessfully rendering quotes on the ada trader homepage, basic functionality for buy and sell (price change) implemented
…used for practice with event bus), wave 2 basic requirement passing
…view by clearing the current contents of the Trade History section. Will need to refactor and clear notes later
…dditional styling
…ught' or 'sold' to elements instead of id because multiple elements will share that status
…v ugly now, just a placeholder until further styling
…w instead of app.js
…en order using a findWhere- had to pass the initialized QuoteList (Quotes) as a parameter for the new OrderListView in app.js so that I could create the connection between an order and the quote it should be listening to. Might need to refactor this later
… messages showing. Still need to implement validity of target Price against current market rates of quotes, and validity of symbol
…en you click the cancel button on the order view
…empt to create an open order
…ng, some refactoring to get rid of unnecessary console logs and params included
Ada TraderWhat We're Looking For
|
Overall, good work! Event-driven programming is always interesting, especially in contrast with the message-driven programming we've done otherwise. Keep in mind that event-driven is not the only solution available. Otherwise, great job! ps: I like the touch of the border colors; it made it easier for me to grade ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ada Trader
Congratulations! You're submitting your assignment!
Comprehension Questions