Pipes - Kee - MediaRanker

[anemonekey]

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	The only model methods I had were validations.
Describe how you approached testing that model method. What edge cases did you come up with?	I tried to get the success/failure case for each test.
Describe an edge case test you wrote for a controller	Checked what to expect from the update method in the Works Controllers when faced with invalid params in conjunction with nonexistent works.
What are session and flash? What is the difference between them?	Session is a hash that keeps track of a user's browser session until it closes. Flash is a hash that sends singular messages from the controller to a view.
Describe a controller filter you wrote.	Added a before action in the Users controller so various methods (show, edit, update, destroy) would get passed in user parameters from the beginning.
What was one thing that you gained more clarity on through this assignment?	I better learned how to test and also learned about sessions and flashes.
What is the Heroku URL of your deployed application	Not working...
Do you have any recommendations on how we could improve this project for the next cohort?	More guided step tutorials would be great. It gets confusing when the notes do not match our lecture vs. what we want to do in the application.

[PilgrimMemoirs]

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Well Done
Comprehension questions	Mostly good - 2nd question should be more specific.
General
Rails fundamentals (RESTful routing, use of named paths)	Well Done
Semantic HTML	Well Done
Errors are reported to the user	Well Done
Business logic lives in the models	❗️ Logic in home_controller index method should be defined as class methods for Work. Set the instance variable as the return value from that method.
Models are thoroughly tested, including relations, validations and any custom logic	Mostly good - tests what's there. Missing opportunity to test logic since it's not defined in model (see above)
Controllers are thoroughly tested	❗️ Good Start - work is well done, votes and users not complete - particularly around logging in
Wave 1 - Media
Splash page shows the three media categories	Well Done
Basic CRUD operations on media are present and functional	Well Done
Wave 2 - Users and Votes
Users can log in and log out	Well Done
The ID of the current user is stored in the session	Well Done
Individual user pages and the user list are present	Well Done
A user cannot vote for the same media more than once	Well Done
All media lists are ordered by vote count	Well Done
Splash page contains a media spotlight	Well Done
Media pages contain lists of voting users	Well Done
Wave 3 - Styling
Foundation is used appropriately	Well Done
Look and feel is similar to the original	Well Done
Overall
Essential functionality is there.
Areas to improve	Identify where code belongs, especially to identify when logic should be defined in a model instead of the controller. Testing with logging in a user - need to see that you can test with checking that session has been set.