[DP-103] Add aiq_day_start() pushdown #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannistze
reviewed
Sep 19, 2024
Comment on lines
+246
to
+259
| val innerTsm = ConstantString("TIMESTAMP_MILLIS") + blockStatement(convertStatement(timestamp, fields)) | ||
| val innerDt = ConstantString("DATETIME") + blockStatement( | ||
| innerTsm + "," + tzStmt | ||
| ) | ||
| val dtAdd = ConstantString("DATETIME_ADD") + blockStatement( | ||
| innerDt + ", INTERVAL " + convertStatement(plusDays, fields) + " DAY" | ||
| ) | ||
| val dtTrunc = ConstantString("DATETIME_TRUNC") + blockStatement( | ||
| dtAdd + ", DAY" | ||
| ) | ||
| val outerTs = ConstantString("TIMESTAMP") + blockStatement( | ||
| dtTrunc + "," + tzStmt | ||
| ) | ||
| ConstantString("UNIX_MILLIS") + blockStatement(outerTs) |
There was a problem hiding this comment.
Can you please put in the tickets for the Spark functions refactoring that this needs cause things are pilling up 🙏
yannistze
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
aiq_day_start(), same test cases as Snowflake hereTest Notes
https://github.com/ActionIQ/spark-bigquery-connector?tab=readme-ov-file#unit-tests
https://github.com/ActionIQ/spark-bigquery-connector?tab=readme-ov-file#integration-tests
Deploy Notes
https://github.com/ActionIQ/spark-bigquery-connector?tab=readme-ov-file#deploy