Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1850 add validate journey for multi step journeys #1860

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Feature/1850 add validate journey for multi step journeys #1860

merged 5 commits into from
Nov 11, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Nov 11, 2024 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (TODO)

@JoernBerkefeld JoernBerkefeld added the c/journey COMPONENT label Nov 11, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.5.0 milestone Nov 11, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Nov 11, 2024
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Nov 11, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Nov 11, 2024 that may be closed by this pull request
[FEATURE] add validate journey for multi-step journeys #1850
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

Coverage Report

Commit:71b7678
Base: develop@bc0cb18

Type Base This PR
Total Statements Coverage  69.94%  69.81%  (-0.13%)
Total Branches Coverage  69.06%  69.08%  (+0.02%)
Total Functions Coverage  81.81%  81.87%  (+0.06%)
Total Lines Coverage  69.94%  69.81%  (-0.13%)
Details (changed files):
File Statements Branches Functions Lines
lib/cli.js  0%  0%  0%  0%
lib/index.js  71.52%  64.74%  72.72%  71.52%
lib/metadataTypes/Event.js  55.48%  41.11%  71.42%  55.48%
lib/metadataTypes/Journey.js  58.98%  59.68%  76.19%  58.98%

@JoernBerkefeld JoernBerkefeld merged commit be76e63 into develop Nov 11, 2024
8 checks passed
@JoernBerkefeld JoernBerkefeld deleted the feature/1850-add-validate-journey-for-multi-step-journeys branch November 11, 2024 21:10
@github-actions github-actions bot mentioned this pull request Nov 11, 2024
Closed
@JoernBerkefeld JoernBerkefeld mentioned this pull request Nov 18, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/journey COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.

[FEATURE] add validate journey for multi-step journeys
1 participant
@JoernBerkefeld