Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/1806 fix cdp's handoff of source-market to buildTemplate #1821

Merged
merged 1 commit into from
Nov 2, 2024
Merged

bug/1806 fix cdp's handoff of source-market to buildTemplate #1821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion @types/lib/metadataTypes/MetadataType.d.ts.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion @types/lib/util/validations.d.ts.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 11 additions & 1 deletion lib/util/devops.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,9 +418,19 @@ const DevOps = {
}
// all good let's loop a second time for actual execution
for (const sourceMlName of sourceMarketListArr) {
/** @type {string} */
const targetMlName = properties.options.deployment.sourceTargetMapping[sourceMlName];
/** @type {string} */
const sourceBU = Object.keys(properties.marketList[sourceMlName])[0];
/** @type {string} */
const sourceMarket = Object.values(properties.marketList[sourceMlName])[0];
if ('string' !== typeof sourceMarket) {
Util.logger.error(
'Deployment Source market list needs to have a 1:1 BU-Market combo. Your value: ' +
sourceMarket
);
return;
}

const delta = Array.isArray(diffArr)
? diffArr
Expand Down Expand Up @@ -465,7 +475,7 @@ const DevOps = {
Util.logger.info(
`⚡ mcdev bt ${bu} ${type} "${keyArr.join(',')}" ${sourceMarket}`
);
await Builder.buildTemplate(bu, type, keyArr, sourceMarket);
await Builder.buildTemplate(bu, type, keyArr, [sourceMarket]);
// ensure we have the right key for bd/bdb that matches the name used for rt
if (keyArr.length) {
if (!typeDelta[type]) {
Expand Down
Loading