Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/1818 no longer include triggeredsend keys in templated journeys to ensure journey metadata is clean #1819

Merged
merged 2 commits into from
Nov 2, 2024
Merged

Task/1818 no longer include triggeredsend keys in templated journeys to ensure journey metadata is clean #1819

merged 2 commits into from
Nov 2, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Nov 2, 2024 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld
#1818: no longer send triggered send key / id during CREATE and dont …
e350d1e 
…save it during templating to ensure a clean new clone in the journey metadata
@JoernBerkefeld
#1818: add missing field config
aae7658
@JoernBerkefeld JoernBerkefeld added this to the 7.4.5 milestone Nov 2, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Nov 2, 2024
@github-actions github-actions bot added the chore Jira issue-type "Task" label Nov 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024 •
edited
Loading

Coverage Report

Commit:aae7658
Base: develop@6916f4c

Type Base This PR
Total Statements Coverage  69.77%  69.77%  (+0%)
Total Branches Coverage  68.42%  68.42%  (+0%)
Total Functions Coverage  81.59%  81.59%  (+0%)
Total Lines Coverage  69.77%  69.77%  (+0%)
Details (changed files):
File Statements Branches Functions Lines

@JoernBerkefeld JoernBerkefeld merged commit c53a992 into develop Nov 2, 2024
11 checks passed
@JoernBerkefeld JoernBerkefeld deleted the task/1818-no-longer-include-triggeredsend-keys-in-templated-journeys-to-ensure-journey-metadata-is-clean branch November 2, 2024 16:45
@JoernBerkefeld JoernBerkefeld linked an issue Nov 2, 2024 that may be closed by this pull request
[TASK] no longer include triggeredSend keys in templated journeys to ensure journey metadata is clean #1818
Closed
@github-actions github-actions bot mentioned this pull request Nov 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/journey COMPONENT c/triggeredSend COMPONENT chore Jira issue-type "Task"
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.

[TASK] no longer include triggeredSend keys in templated journeys to ensure journey metadata is clean
1 participant
@JoernBerkefeld