Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/745 get mobileCode and mobileKeyword for importActivities with target SMS-list #1209

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Feb 6, 2024

PR details

What changes did you make? (Give an overview)

Further details (optional)

  • this covers getting additional relevant data for the mobile imports
  • there will need to be an additional PR to cover deployments of such mobile imports

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 6.1.0 milestone Feb 6, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Feb 6, 2024
@github-actions github-actions bot added the bug Something isn't working label Feb 6, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Feb 6, 2024 that may be closed by this pull request
2 tasks
Copy link

github-actions bot commented Feb 23, 2024

Coverage Report

Commit:24db8cd
Base: develop@e63e197

Type Base This PR
Total Statements Coverage  64.57%  64.45%  (-0.12%)
Total Branches Coverage  66.21%  66.13%  (-0.08%)
Total Functions Coverage  74.05%  74.09%  (+0.04%)
Total Lines Coverage  64.57%  64.45%  (-0.12%)
Details (changed files):
File Statements Branches Functions Lines

@JoernBerkefeld JoernBerkefeld merged commit b6016f6 into develop Feb 23, 2024
7 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bugfix/745-cannot-deploy-import-file-activity-with-destination-sms branch February 23, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cannot deploy Import file Activity with destination SMS
1 participant