Skip to content

Commit

Permalink
#1806: fix cdp's handoff of source-market to buildTemplate
Browse files Browse the repository at this point in the history
  • Loading branch information
JoernBerkefeld committed Nov 2, 2024
1 parent 88af279 commit 30ff95d
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 3 deletions.
2 changes: 1 addition & 1 deletion @types/lib/metadataTypes/MetadataType.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion @types/lib/util/validations.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 11 additions & 1 deletion lib/util/devops.js
Original file line number Diff line number Diff line change
Expand Up @@ -418,9 +418,19 @@ const DevOps = {
}
// all good let's loop a second time for actual execution
for (const sourceMlName of sourceMarketListArr) {
/** @type {string} */
const targetMlName = properties.options.deployment.sourceTargetMapping[sourceMlName];
/** @type {string} */
const sourceBU = Object.keys(properties.marketList[sourceMlName])[0];
/** @type {string} */
const sourceMarket = Object.values(properties.marketList[sourceMlName])[0];
if ('string' !== typeof sourceMarket) {
Util.logger.error(
'Deployment Source market list needs to have a 1:1 BU-Market combo. Your value: ' +
sourceMarket
);
return;
}

const delta = Array.isArray(diffArr)
? diffArr
Expand Down Expand Up @@ -465,7 +475,7 @@ const DevOps = {
Util.logger.info(
`⚡ mcdev bt ${bu} ${type} "${keyArr.join(',')}" ${sourceMarket}`
);
await Builder.buildTemplate(bu, type, keyArr, sourceMarket);
await Builder.buildTemplate(bu, type, keyArr, [sourceMarket]);
// ensure we have the right key for bd/bdb that matches the name used for rt
if (keyArr.length) {
if (!typeDelta[type]) {
Expand Down

0 comments on commit 30ff95d

Please sign in to comment.