Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GUI-related code #210

Merged
merged 11 commits into from
Apr 14, 2024
Merged

Refactor GUI-related code #210

merged 11 commits into from
Apr 14, 2024

Conversation

marcus-ny
Copy link

Fixes #203

Changelog

  • Remove unused methods and code in Analytics.java
  • Remove testcases related to removed methods
  • Create TabIndicator.java to represent which tab to display currently
  • Refactor tab switching logic to be handled by observable TabIndicator in Model class
  • Minor tweaks to naming conventions (loaneeInfoFlag renamed to isShowLoaneeInfo)

@marcus-ny marcus-ny added the priority.High Must do label Apr 14, 2024
@marcus-ny marcus-ny added this to the v1.4 milestone Apr 14, 2024
@marcus-ny marcus-ny self-assigned this Apr 14, 2024
@marcus-ny marcus-ny force-pushed the branch-refactor-GUI-code branch from 7bb4dff to 2b2c3ae Compare April 14, 2024 13:05
@marcus-ny marcus-ny requested a review from kjw142857 April 14, 2024 13:35
Joseph31416
Joseph31416 approved these changes Apr 14, 2024
View reviewed changes
Copy link

@Joseph31416 Joseph31416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored code does not introduce regression and all features have the same expected behaviour, well done!

kjw142857
kjw142857 approved these changes Apr 14, 2024
View reviewed changes
Copy link

@kjw142857 kjw142857 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@kjw142857 kjw142857 merged commit f4c7534 into AY2324S2-CS2103T-W13-1:master Apr 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjw142857 kjw142857 kjw142857 approved these changes

@Joseph31416 Joseph31416 Joseph31416 approved these changes

Assignees

@marcus-ny marcus-ny

Labels
priority.High Must do
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Refactor Analytics and GUI related code
3 participants
@marcus-ny @Joseph31416 @kjw142857