Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace loan value types with BigDecimals #123

Merged

Conversation

kjw142857
Copy link

Fixes #121.

  • Replaces all representation of loan values as int/float with BigDecimal, which prevents string conversion errors.
  • Updated the JavaDoc documentation.

@kjw142857 kjw142857 added priority.Medium Nice to have type.Bug A bug severity.Medium Occasional inconvenience to some users labels Apr 4, 2024
@kjw142857 kjw142857 added this to the v1.3 milestone Apr 4, 2024
@kjw142857 kjw142857 self-assigned this Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 47.04%. Comparing base (8b0e1d6) to head (91cb2c5).

Files Patch % Lines
...ain/java/seedu/address/model/person/Analytics.java 0.00% 15 Missing ⚠️
...ava/seedu/address/model/person/UniqueLoanList.java 0.00% 4 Missing ⚠️
src/main/java/seedu/address/ui/AnalyticsPanel.java 0.00% 4 Missing ⚠️
src/main/java/seedu/address/model/person/Loan.java 0.00% 3 Missing ⚠️
.../seedu/address/logic/commands/EditLoanCommand.java 0.00% 2 Missing ⚠️
...in/java/seedu/address/logic/parser/ParserUtil.java 0.00% 2 Missing ⚠️
...a/seedu/address/model/analytics/DashboardData.java 0.00% 2 Missing ⚠️
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% 2 Missing ⚠️
.../seedu/address/logic/commands/LinkLoanCommand.java 0.00% 1 Missing ⚠️
...rc/main/java/seedu/address/model/ModelManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #123      +/-   ##
============================================
- Coverage     47.06%   47.04%   -0.03%     
  Complexity      433      433              
============================================
  Files            99       99              
  Lines          2267     2268       +1     
  Branches        227      227              
============================================
  Hits           1067     1067              
- Misses         1155     1156       +1     
  Partials         45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@marcus-ny marcus-ny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm! 👍

@marcus-ny marcus-ny merged commit 8e5d841 into AY2324S2-CS2103T-W13-1:master Apr 4, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have severity.Medium Occasional inconvenience to some users type.Bug A bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linkloan fails to handle >= 9 digit inputs
2 participants