Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT REVIEW - 2.8 search monitor alert count fix #11

Draft
wants to merge 8 commits into
base: 2.8
Choose a base branch
from

Conversation

AWSHurneyt
Copy link
Owner

… from being returned.

Issue #, if available:

Description of changes:

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.15 ⚠️

Comparison is base (3f2e86b) 75.32% compared to head (969ddfc) 75.18%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.8      #11      +/-   ##
============================================
- Coverage     75.32%   75.18%   -0.15%     
  Complexity      116      116              
============================================
  Files           141      141              
  Lines          8418     8421       +3     
  Branches       1203     1204       +1     
============================================
- Hits           6341     6331      -10     
- Misses         1468     1482      +14     
+ Partials        609      608       -1     
Impacted Files Coverage Δ
...alerting/transport/TransportSearchMonitorAction.kt 77.77% <100.00%> (+1.58%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AWSHurneyt AWSHurneyt force-pushed the 2.8_search_monitor_alert_count_fix branch from c3378d6 to 969ddfc Compare July 7, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants