Concurrent downloads #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forrestfwilliams
added
the
bumpless
jtherrmann
reviewed
Apr 11, 2023
Co-authored-by: Jake Herrmann <[email protected]>
forrestfwilliams
added
patch
jtherrmann
approved these changes
Apr 12, 2023
jhkennedy
reviewed
Apr 12, 2023
Comment on lines
+329
to
+333
| with ThreadPoolExecutor(max_workers=10) as executor: | ||
| xml_futures = [executor.submit(download_metadata, asf_session, params) for params in param_list] | ||
| tiff_futures = [executor.submit(download_burst, asf_session, params) for params in param_list] | ||
| metadata_xmls = [future.result() for future in xml_futures] | ||
| burst_paths = [future.result() for future in tiff_futures] |
There was a problem hiding this comment.
Cool! Be nice to add this to the SDK too: ASFHyP3/hyp3-sdk#113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on the burst extractor in serial to perform data downloads was taking up a large percentage of the total processing time. This PR refactors the
download_burstsfunction to concurrently download the data we need, significantly decreasing the overall processing time.