Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the tabBar Color #218

Closed
wants to merge 2 commits into from
Closed

Conversation

Chalhotra
Copy link
Contributor

Description

Fixes the color of the tabBar indicator to make it consistent iwth the entire app's yellow theme

Fixes #217

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Since it's only a UI change, there's nothing different to test, it works as expected below attached are screenshots

Please include screenshots below if applicable.
Screenshot 2024-12-27 at 11 29 04 PM image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@Chalhotra Chalhotra requested a review from jddeep as a code owner December 27, 2024 18:00
@navaneeth0041
Copy link
Contributor

@Chalhotra I was waiting for it to be assigned

@navaneeth0041
Copy link
Contributor

Not a good practice I guess.

@Chalhotra
Copy link
Contributor Author

oh... my bad I just saw the issue and made the PR, I'll close it asap, really sorry for the inconvenience 🥲

@Chalhotra Chalhotra closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabBar indicator color not matching application theme
2 participants