Updated backend script, fixes installation #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manthanabc instead of removing the |
|
done, also if this is supposed to be a setup script for the backend, maybe we should move requirements file to backend since its specific to the backend, and have the script also install the dependencies. i can create a separate pr for it, if this is desirable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76 , By updating the backend/script.sh file,
Adds cleanup section,
Increases verbosity,
Removes redundant venv creation,
Fixes paths, now the script should be ran from backend folder as described in readme.md
Note: Maybe this file should be called get s2v .sh instead of script.sh