Fix: MCQ Generation Page Break and Missing Options #110
+3
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
I believe the question statement must be changed also to question_statement like in #86, other wise it does'nt show correct question statement. |
|
@manthanabc i believe we are getting the output as before, hence making a small change on Frontend would work in this case |
|
@Naman-B-Parlecha pls ensure that everything is working now after these changes. If possible, share a webcast with the working solution. |
Screencast.from.2025-01-07.11-59-44.webm@Aditya062003 there is no breaking, after the fix |
|
I think this issue has already been fixed with the PDF generation, so we don't need a separate PR or issue for this. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where the MCQ generation process caused the page to break (#109). It also ensures all generated MCQs display their options correctly.
Note: In order to generate this PR on a local GPU, make use of the changes introduced in PR #107.
Closes #109
Before Fix
https://github.com/user-attachments/assets/329bab79-9f9e-4cb1-a1e2-aeda46ee0712
After Fix
Screencast from 2025-01-07 11-59-44.webm