Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added js for profile icon, login, signup and hamburger menu in responsive mode #1698

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

shivam8112005
Copy link
Contributor

@shivam8112005 shivam8112005 commented Nov 5, 2024

Pull Request Checklist

Fixes #1690

  • I have added screenshots and videos to show before and after the working of my code.
  • I have ensured that the screen size is set to 100% while making the video.
  • I have synced the latest fork with my local repository and resolved any conflicts.
  • I have mentioned the issue number which I created before making this PR .(format to mention issue number is : fixes #(issue number) )
  • I understand that if any the above conditions are not met , my PR will not be MERGED .
    After:
Screen.Recording.2024-11-05.213745.mp4

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
word-wise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 4:08pm

@shivam8112005
Copy link
Contributor Author

@ANSHIKA-26 if possible can you please review it before midnight

@ANSHIKA-26
Copy link
Owner

can you also fix this ?
image

@shivam8112005
Copy link
Contributor Author

shivam8112005 commented Nov 5, 2024

@ANSHIKA-26 yes , I will open new issue for it by tomorrow but for now can you merege it if js is implementd correctly

@ANSHIKA-26 ANSHIKA-26 merged commit e7bb7dc into ANSHIKA-26:main Nov 6, 2024
4 of 6 checks passed
Copy link

github-actions bot commented Nov 6, 2024

🎉🎉 Thank you for your contribution! Your PR #1698 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hamburger menu and profile icon javascript is not working on my reading list page
2 participants