Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set logging level to emit all logs #162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vivianrwu
Copy link
Contributor

Set logger to emit all logs. Previously was set to INFO logs only then WARNING logs only. Not setting the logger will emit all logs. This reenables viewing the INFO logs in JetStream server logs.

Validated logic in maxengine-server to emit INFO logs-

2025-01-10 02:20:18,057 - root - INFO - Detokenizing generate step 209 took 22.56ms
INFO:root:Detokenizing generate step 210 took 22.98ms
{"message": "Detokenizing generate step 210 took 22.98ms","severity": "INFO", "logging.googleapis.com/labels": {"python_logger": "root"}, "logging.googleapis.com/trace": "", "logging.googleapis.com/spanId": "", "logging.googleapis.com/trace_sampled": false, "logging.googleapis.com/sourceLocation": {"line": 897, "file": "/usr/local/lib/python3.10/dist-packages/jetstream/core/orchestrator.py", "function": "_detokenize_thread"}, "httpRequest": {} }
2025-01-10 02:20:18,080 - root - INFO - Detokenizing generate step 210 took 22.98ms

@vivianrwu vivianrwu requested a review from vipannalla as a code owner January 10, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant