-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package: Unpin topoly version #995
Conversation
Rebase this branch after #988 has been merged to resolve the issues with |
Tests using [`pytest-regtest-2.3.2`](https://pypi.org/project/pytest-regtest/#history) are [failing on OSX](https://github.com/AFM-SPM/TopoStats/actions/runs/11780199328/job/32810287345?pr=988) pegging version to `pytest-regtest==2.3.1` to see if this resolves the issue.
faf8e67
to
e115d0d
Compare
I've manually updated the necessary files so that the change in nomenclature used by Still feel we should be using |
Do we also need to pin numpy < 2 from Pawel's comment: "There seems to be some incompatibility with numpy 2.x. We built the 1.0.4 version before numpy 2.x was out and there are no issues with older numpy versions" |
Full comment for context (bold emphasis is mine)...
Until we get bitten by whatever the problem is (and we don't have enough details to know what that is) I'd say no, not at the moment1. Numpy 2.0.0 was a significant release, hence the major semantic version change with breakages to be expected and was made 5 months ago. There have been minor revisions since (current stable version is 2.1.3 released 2024-11-02). Long term, keeping up-to-date with revisions is important otherwise you end up in the situation when I first came to work on TopoStats with Docker containers running unsupported software. For that reason I'm not a fan of pinning version dependencies for long periods, it kicks the can of fixing whatever is broken further down the line. Further, and perhaps more fundamentally, if Footnotes
|
Wheels are now available for all OS's and architectures (thanks @prubach 👍 )
Closes #994