Skip to content

Commit

Permalink
Revert "Close datastore after task_finished has been invoked (Netflix…
Browse files Browse the repository at this point in the history
…#757)" (Netflix#783)

This reverts commit 8a54a42.
  • Loading branch information
savingoyal authored Oct 25, 2021
1 parent 2c75494 commit eee086a
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions metaflow/task.py
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,10 @@ def run_step(self,
output.save_metadata({'task_end': {}})
output.persist(self.flow)

# this writes a success marker indicating that the
# "transaction" is done
output.done()

# final decorator hook: The task results are now
# queryable through the client API / datastore
for deco in decorators:
Expand All @@ -506,10 +510,6 @@ def run_step(self,
retry_count,
max_user_code_retries)

# this writes a success marker indicating that the
# "transaction" is done
output.done()

# terminate side cars
logger.terminate()
self.metadata.stop_heartbeat()

0 comments on commit eee086a

Please sign in to comment.