Embedded #31
Open
Embedded #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigi-rosso
reviewed
Oct 2, 2019
| @@ -6,13 +6,13 @@ const APP_DIR = path.resolve(__dirname, "source/"); | |||
| const config = | |||
| { | |||
| mode: "development", | |||
| target: "web", | |||
| target: "node", | |||
There was a problem hiding this comment.
I wonder if we should make two different webpack config files. One for webpacking for node and one for web. Maybe webpack.node.config.js and webpack.web.config.js and then have two separate scripts in package.json for building each. Probably want to configure each to build a different .min.js file for each too.
There was a problem hiding this comment.
That's probably a good idea
There was a problem hiding this comment.
Although I wonder how other libraries handle this such that you can reference a single npm module for both. I think for now two versions of webpack.config is probably most efficient, but I would like to see if there's something inherently more efficient for this...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for node