-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Multi-Language Support to Minio #2975
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pt-br: Animação de login do WebUI | ||
ru: Анимация входа в WebUI | ||
zh-Hant: WebUI 登入動畫 | ||
zh: WebUI 登录动画 No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code diff seems to correct some labels for various fields related to panel configuration settings, replacing placeholder names with appropriate translations. Here are the changes:
- Added Japanese translations for all label keys.
- Corrected capitalization on certain English words.
Overall, this change enhances readability and usability for users who may be working in multiple languages.
pt-br: Servidor de armazenamento de objetos de código aberto | ||
ru: Открытый сервер объектного хранения | ||
zh-Hant: 開源物件儲存伺服器 | ||
zh: 开源对象存储服务器 | ||
type: tool | ||
crossVersionUpdate: true | ||
limit: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The provided code appears to be YAML metadata for an entry in a configuration or documentation schema. However, it contains several inconsistencies and could benefit from some adjustments:
- Duplicate Metadata: The
additionalProperties
field is repeated with- Middleware
, which should either be removed or unified. - Missing Descriptions:
- There is no description key present that matches the language keys used elsewhere. For example, there's only an "eng" section in
description
, but not sections for Japanese (ja
), Malay (ms
), Brazilian Portuguese (pt-br
), Russian (ru
), Chinese Traditional (zh-Hant
), or simplified Chinese (zh
).
- There is no description key present that matches the language keys used elsewhere. For example, there's only an "eng" section in
- Cross-Version Update Setting: While
crossVersionUpdate
is set totrue
, it might require further clarification on what version of schemas this applies to.
Overall, the code needs to ensure consistency across multiple languages under the description
key and provide descriptions for each language listed if needed. It may also need a more uniform structure or removal of duplicate properties.
No description provided.