Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/extract New Relic middleware #69

Open
PetrGlad opened this issue Dec 7, 2016 · 1 comment
Open

Remove/extract New Relic middleware #69

PetrGlad opened this issue Dec 7, 2016 · 1 comment

Comments

@PetrGlad
Copy link
Contributor

PetrGlad commented Dec 7, 2016

The New Relic dependency is out of scope of the project and is not required in most cases. OTOH it can be useful as a separate Ring middleware somewhere else. So I suggest to extract New Relic adapter into separate library project.
I can do code changes but since I do not use New Relic I would be unable to verify that it still works.
As an alternative I can prepare the PR that just removes New Relic adapter.

@sebastianpoeplau
Copy link
Contributor

I agree that it should be factored out, but I'm not a New Relic user either. Maybe @harti2006 or @prayerslayer can comment...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants