Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intero support #1009

Open
noughtmare opened this issue Jul 27, 2017 · 5 comments
Open

Intero support #1009

noughtmare opened this issue Jul 27, 2017 · 5 comments

Comments

@noughtmare
Copy link
Member

noughtmare commented Jul 27, 2017

I've started work on using intero with Yi in my own yi-config.

It works by starting stack ghci --with-ghc intero in the background and sending requests via MVars. I currently have one big Request type which is a sum of all possible requests, but I think it should be possible to have less duplication of code and more extensibility.

Currently it only supports vim ex commands, but it should be pretty easy to bind them to your favourite keybindings.

My next step will probably be to release it as a proper Yi package, but a problem is how the MVar that does the communication is stored. At the moment I store it in an MVar that is created when Yi is launched, but I don't think that will be easy to do when it is split into it's own package. An alternative would be to store it in as a YiVariable.

@noughtmare noughtmare self-assigned this Jul 27, 2017
@noughtmare
Copy link
Member Author

noughtmare commented Jul 27, 2017

I have created a separate github repo https://github.com/noughtmare/yi-intero.

Should we merge it with this repo or keep it like this? I think that it is already getting quite crowded in this repo and intero is not essential.

@ethercrow
Copy link
Member

You can create yi-editor/yi-intero.

One man's crowdedness is another man's discoverability. I also like having plugins in this repo because this way it's possible to add a feature to core and use it from a plugin in a single commit.

@ethercrow
Copy link
Member

Nice!

Could you make some screenshots or a video for the blog showcasing what's already there and what's next and how people can help? I imagine there might be brave souls wanting to help with intero integration.

@noughtmare
Copy link
Member Author

I have added a todo list in the README. It also explains what is already implented and how to use it with a link to my own yi config where I'm using it.

It is in my opinion not yet ready for screenshots and videos, because it simply opens a new split window to display the results of commands and a lot of useful functionality is not yet implemented. It is still in the proof of concept stage.

I'm working on better documentation now.

BTW: Should I just keep pushing every update to the main repo directly or is it better to first develop it in a fork and then request a merge when the package is more stable?

@ethercrow
Copy link
Member

BTW: Should I just keep pushing every update to the main repo directly or is it better to first develop it in a fork and then request a merge when the package is more stable?

Since you're not breaking anything for anyone until there's a second user, feel free to push it directly.

@noughtmare noughtmare removed their assignment Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants