You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is this the final version of your code because as I recall you wrote about format inference in your paper. But in your code the only thing I found about format inference is the comment "## TODO: format inference" in netplier.py. Furthermore in your file tmp_results/dnp3/msa_fields_visual.txt in line 2, I noticed the Field "3c~0" which doesn't seem like a valid message byte to me. Because of the reasons I've given above it got me thinking if this code is not the final version of your implementation.
Thanks,
Kerim
The text was updated successfully, but these errors were encountered:
I think in some instances the alignment algorithm breaks bytes apart on Nibble (Half-Byte) boundaries. I assume this is because alignment algorithms are string based where each character is a token and it doesn't know to keep the nibbles together.
Hi,
Is this the final version of your code because as I recall you wrote about format inference in your paper. But in your code the only thing I found about format inference is the comment "## TODO: format inference" in netplier.py. Furthermore in your file tmp_results/dnp3/msa_fields_visual.txt in line 2, I noticed the Field "3c~0" which doesn't seem like a valid message byte to me. Because of the reasons I've given above it got me thinking if this code is not the final version of your implementation.
Thanks,
Kerim
The text was updated successfully, but these errors were encountered: