Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version of your code #8

Open
Kerim-13 opened this issue Sep 23, 2022 · 1 comment
Open

Version of your code #8

Kerim-13 opened this issue Sep 23, 2022 · 1 comment

Comments

@Kerim-13
Copy link

Kerim-13 commented Sep 23, 2022

Hi,

Is this the final version of your code because as I recall you wrote about format inference in your paper. But in your code the only thing I found about format inference is the comment "## TODO: format inference" in netplier.py. Furthermore in your file tmp_results/dnp3/msa_fields_visual.txt in line 2, I noticed the Field "3c~0" which doesn't seem like a valid message byte to me. Because of the reasons I've given above it got me thinking if this code is not the final version of your implementation.

Thanks,
Kerim

@jaredchandler
Copy link

jaredchandler commented Mar 31, 2023

I think in some instances the alignment algorithm breaks bytes apart on Nibble (Half-Byte) boundaries. I assume this is because alignment algorithms are string based where each character is a token and it doesn't know to keep the nibbles together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants