Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lot of warnings when building with msvc #127

Open
volcoma opened this issue Feb 18, 2024 · 1 comment
Open

A lot of warnings when building with msvc #127

volcoma opened this issue Feb 18, 2024 · 1 comment

Comments

@volcoma
Copy link

volcoma commented Feb 18, 2024

I am building edyn as part of my project and am using the highest warning level and had to basically do this to silence all the warnings coming from edyn.
Maybe you should take a look at them when you have a chance.

if(MSVC)
    add_compile_options(/wd4244 /wd4100 /wd4996 /wd4701 /wd4305 /wd4267 /wd4127 /wd4456 /wd4458)
endif()

add_subdirectory(edyn)

P.s sorry for the multiple issues. I am enjoying the library very much and am trying to integrate it in a game engine.

@xissburg
Copy link
Owner

Thanks for opening the issue. IIRC it's mostly unused argument and type conversion warnings. I'll have to clean this up eventually. Windows is not my primary platform so I don't give it as much attention.

I appreciate opening issues. It is really helpful to identify what's broken in the library and other ways to improve it, since my personal use cases and scope won't ever cover everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants