Group gets fully replaced when sync is used and group previously failed to load

[StephanBijzitter]

When everything goes correctly:

• If option 1 is used, the group on wom will match whatever is currently in the clan list
• If option 2 is used, any users in the clan list not yet in the group are added to the group and any users in the clan list with a different rank/role have their rank/role updated on wom

However, the code for option 2 relies on the plugin having an up-to-date copy of the group as represented on wom; if this copy is not up-to-date or is missing (due to any kind of connectivity issue), option 2 becomes functionally identical to option 1.

The following code is responsible for this unexpected behaviour:

wiseoldman-runelite-plugin/src/main/java/net/wiseoldman/ui/SyncButton.java

Lines 137 to 140 in ec4d95c

	if (!overwrite)
	{
	groupMembers.forEach((k, v) -> clanMembers.put(k, new Member(v.getPlayer().getDisplayName(), v.getRole())));
	}

A simple workaround would be to check the size of groupMembers, if this is 0 then that can mean two things:

• either there was an issue downloading a copy, in which case it would be better to abort than to proceed
• or the group actually has 0 members, in which case option 1 would be semantically more accurate to be used anyway

[StephanBijzitter]

Ideally though the endpoint used should be changed to use the POST variant (assuming that adding an existing member with a different rank, will update that member's rank): https://docs.wiseoldman.net/groups-api/group-endpoints#add-members