Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a way to automatically merge on all-green #6296

Closed
zcorpan opened this issue Jun 20, 2017 · 4 comments
Closed

Support a way to automatically merge on all-green #6296

zcorpan opened this issue Jun 20, 2017 · 4 comments

Comments

@zcorpan
Copy link
Member

zcorpan commented Jun 20, 2017

I sometimes approve a PR but also re-run a failed check, or review a new PR before checks have completed. Then I leave the tab and it can go an unknown amount of time until I or someone else gets back to it to merge, or the PR author pings the PR asking why it's not merged yet, which is unfortunate.

I've requested a feature to do this to github some months ago, but it's not there yet. But it should be possible to do this per-repo with Travis CI, I think? For example, we could support having a label "auto-merge on all-green", which maybe squashes and merges if there are several commits, and rebases and merges if there's a single commit, if all checks are green (and there's an approved review).

Thoughts?

cc @tobie

@zcorpan zcorpan added the infra label Jun 20, 2017
@tobie
Copy link
Contributor

tobie commented Jun 20, 2017

Happy to work on this if someone is willing to fund that work.

@jgraham
Copy link
Contributor

jgraham commented Jul 15, 2017

@bobholt is this on your radar? Seems like it oculd be added to the wptdash, perhaps?

@bobholt
Copy link
Contributor

bobholt commented Jul 17, 2017

@jgraham: Yeah, I could look into that.

@zcorpan
Copy link
Member Author

zcorpan commented Jun 18, 2018

@zcorpan zcorpan closed this as completed Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants