Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Replace ESLint with Biome #5506

Closed
chenjiahan opened this issue Mar 6, 2024 · 8 comments · Fixed by #6039
Closed

[Feature]: Replace ESLint with Biome #5506

chenjiahan opened this issue Mar 6, 2024 · 8 comments · Fixed by #6039
Assignees
Labels

Comments

@chenjiahan
Copy link
Member

What problem does this feature solve?

ESLint has obvious performance issues in large monorepos like modern.js.

We can use Biome as the linter to replace ESLint, which can reduce dependencies and improve the lint performance.

Ref:

What does the proposed API look like?

  1. Add Biome to the Modern.js repo and replace ESLint.
  2. Consider adding Biome to the project templates of Modern.js App and Module.
  3. If 1 and 2 are done, we can remove the @modern-js/eslint-config package and reduce the maintenance overhead.
@kirillbashtenko
Copy link
Contributor

Hello @chenjiahan , I'm curious why not oxclint since it's already part of the ecosystem?

@chenjiahan
Copy link
Member Author

@kirillbashtenko Both Biome and OXC can be used to speed up linting, Modern.js choose to use Biome because it can be used for both linting and formatting.

Here is a discussion for comparison: biomejs/biome#1281

@kirillbashtenko
Copy link
Contributor

Thank you, now it's clear!

@YanPes
Copy link

YanPes commented Jun 14, 2024

@chenjiahan thank you for opening the issue. Would love to use biome with modernjs for our code bases

@ScriptedAlchemy
Copy link
Contributor

bumpinng

@YanPes
Copy link

YanPes commented Jun 18, 2024

@chenjiahan Is it planned to have a dedicated set of "default" fields or will you use the standard biome "recommended" list as default?

@chenjiahan
Copy link
Member Author

I prefer following the standard biome "recommended" list because it is well designed.

@caohuilin caohuilin linked a pull request Aug 3, 2024 that will close this issue
3 tasks
@YanPes
Copy link

YanPes commented Aug 16, 2024

Thank you for this 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants