Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treasure Table's have broken again #549

Open
1 task done
j-dan-1 opened this issue Nov 20, 2024 · 3 comments
Open
1 task done

Treasure Table's have broken again #549

j-dan-1 opened this issue Nov 20, 2024 · 3 comments
Assignees
Labels
bug Something isn't working triage This bug still needs to be validated and weighted

Comments

@j-dan-1
Copy link

j-dan-1 commented Nov 20, 2024

What happened?

Rolling the rollable tables for treasures from the compendium for both the paid advance compendium and the basic OSE compendium either returns a result of "No Items" or " [Object Promise] ".

Example when rolling from the Advance Compendiums, I set one of the items to have a 100% to roll just to be sure it wasn't extremely bad luck.
image

Another users screen shot rolling from the Basic OSE compendium tables.
image

What is the expected behaviour?

Using the first screen shot as a example rolling that table should at least result in a result of 1,000 to 6,000 GP appearing in the chat card.

Relevant Errors and Warnings

No response

Additional Support Details

Foundry Version 12 Build 331

Foundry VTT Core Version

None

Old-School Essentials Core Version

2.0.2

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@j-dan-1 j-dan-1 added bug Something isn't working triage This bug still needs to be validated and weighted labels Nov 20, 2024
@JustinFreitas
Copy link
Contributor

I have a fix for that in this pull request. Hope it helps you.

#545

@HeIenth
Copy link

HeIenth commented Dec 19, 2024

I have a fix for that in this pull request. Hope it helps you.

#545

Hello, assuming I'm total noob when it comes to using Github and creating Foundry modules, how do I apply these changes to my local version of OSE system? This is important functionality I need for my games, so I would appreciate any help or advice on how to do it :)

@wyrmisis
Copy link
Collaborator

@HeIenth The most straightforward way is for us to review @JustinFreitas 's code, get it merged into the system, then get a release cut. You could pull the code for his branch down and build the system yourself, if you're comfortable doing so, but at that point your eyeballs on Justin's PR would be just as valuable as anyone else's. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage This bug still needs to be validated and weighted
Projects
None yet
Development

No branches or pull requests

5 participants