Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default visibility setting of battery monitors in "Battery measurements" #1396

Open
ReinvdZee opened this issue Nov 19, 2024 · 1 comment
Open
Assignees
Labels
Milestone

Comments

@ReinvdZee
Copy link
Collaborator

When clicking the battery drilldown, the user is redirected to a list of battery monitors:
image

Available battery monitors can be set to 'visible' or 'hidden' in system setup -> Battery monitors:

image

By default, all battery monitors are hidden, except the active battery monitor. We should improve this by enabling 'dedicated' battery monitors (smartshunts, BMSes, etc.) by default.

The setting to show or hide a battery monitor is e.g. Settings/SystemSetup/Batteries/Configuration/com_victronenergy_battery/2/1/Enabled

@ReinvdZee ReinvdZee self-assigned this Nov 19, 2024
ReinvdZee added a commit to victronenergy/dbus-systemcalc-py that referenced this issue Jan 3, 2025
ReinvdZee added a commit to victronenergy/dbus-systemcalc-py that referenced this issue Jan 3, 2025
@ReinvdZee
Copy link
Collaborator Author

Systemcalc defines several types of battery trackers, each corresponding to a certain service providing battery data. I'd say the com.victronenergy.battery service is the only one dedicated battery monitor. For this type, both a BatteryTracker and a SecondaryBatteryTracker are created. The first is the main battery tracker, and the second tracks /Dc/1/Voltage, e.g. the starter battery voltage.

For example, the smartshunt has both trackers:
image

We can enable the visibility of the main tracker such that only the main tracker of com.victronenergy.battery services is visible by default (like in the screenshot above). I drafted an implemenation for this.

@izak @mpvader Is this the desired behavior?

@ReinvdZee ReinvdZee added this to the v3.60 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant